On Tools > Patron import there is a link labelled "here" on the right side that should be improved (see depending bug 26722).
*** Bug 26759 has been marked as a duplicate of this bug. ***
Created attachment 112389 [details] [review] Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Bug 26724: Improve link text for downloading the CSV file on patron import page On tools > Patron Import there is a link labeled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch 5. Repeat steps 1-2 6. Observe the updated link. 7. Sign off
I would suggest removing "here". That is, just say "Download a starter CSV file with all the columns."
If you look at the examples on the main bug I think we should maybe also remove "Download" and just have "Starter CSV file" or "Sample CSV file" in the link text.
+1
Created attachment 112478 [details] [review] Followup patch to further improve link text for downloading the CSV file on the patron import page. Bug 26724: Improve link text for downloading the CSV file on the patron import page. On tools > Patron import there is a link labeled "here' on the right hand side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Select "Import Patrons" 3. On the right side of the screen observe the "here" link in the text. 4. Apply patch. 5. Refresh page 6. Observe the updated link
Created attachment 112479 [details] [review] Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Bug: 26724: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a link labeled "here" on the right side that should be more descriptive. This patch updated the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page. 6. Obsesrve the updated link text. 7. Sign off
The patch no longer applies 8-( root@kohadevbox:koha(master)$ git bz apply 26724 Bug 26724 - Improve link text for downloading the CSV file on patron import page 112479 - Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug: 26724: Improve link text for downloading the CSV file on patron import page. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt). error: could not build fake ancestor Patch failed at 0001 Bug: 26724: Improve link text for downloading the CSV file on patron import page. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Attachment-to-Bug-26724---Improve-link-text-for-do-JLSMdI.patch
Created attachment 112582 [details] [review] Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Bug: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off
Created attachment 112586 [details] [review] Bug: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off https://bugs.koha-community.org/show_bug.cgi?id=26724 Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112802 [details] [review] Bug 26724: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off https://bugs.koha-community.org/show_bug.cgi?id=26724 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!