Rather than display a number for always available title, we should just display 'Always available'
Created attachment 112022 [details] [review] Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 999999 copies available 6 - Apply patch 7 - Note they now say 'Always available'
Created attachment 112197 [details] [review] Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 999999 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 112222 [details] [review] Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 999999 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 112223 [details] [review] Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 999999 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I couldn't follow the test plan, but have verified the code looks correct and checked the API documentation: https://developer.overdrive.com/apis/library-availability-new
Pushed to master for 20.11, thanks to everybody involved!
does not apply cleanly to 20.05.x, no backport
Created attachment 113937 [details] [review] Bug 26747: [20.05.x] Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 999999 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>