The "Download" link on the OPAC list contents page was broken by the Bootstrap 4 upgrade. I think it relied on a feature of Bootstrap 2.x which allowed one to specify a link target in the modal trigger which would be loaded via AJAX. I think rather than restoring the AJAX version it's probably better to create a dropdown menu matching the one in the OPAC cart.
Created attachment 112041 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC
Created attachment 112229 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
I confirm that there is a bug in master, and that the patch fixes it
Created attachment 112246 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
missing dependencies for 20.05.x, no backport