In a new installation of Koha renewals in the OPAC are not possible because of the default setting for OpacRenewalAllowed. I think we should change the default to make things more obvious for new users.
Created attachment 112332 [details] [review] bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst
Created attachment 112352 [details] [review] bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112355 [details] [review] Nug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112356 [details] [review] Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind <david@davidnind.com>
Passing QA, but noting that on hea the majority of installs do not enable this preference. Maybe this default fixes it, but worth mentioning Also, please remember to capitalize the "B" in 'bug' in your commit titles ;-)
Created attachment 112934 [details] [review] Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Added missing signed-off-by line.
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x