Created attachment 112487 [details] Error trace - listing items for a course reserve After adding an item to a course: - you cannot view the items for the course in the staff interface, and - there is an error trace message. You can view the items as expected in the OPAC. To recreate: 1. In the staff interface go to course reserves. 2. Add a new course. 3. Add a reserve (Add reserves > add a valid barcode > submit). 4. Go to the list of courses and select the course you added the item to. 5. An error trace log is generated - see attachment. Tested on master using koha-testing-docker. Functionality works as expected in 20.05.x. Identified when testing bug 19532
Confirmed on master with kohadevbox. My item was 39999000000276 from sample data.
Created attachment 112848 [details] [review] Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors!
Created attachment 112861 [details] [review] Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112878 [details] [review] Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Caused by commit 9bbf90969304943210e24dcd69422c9fe7d28303 Bug 26323: (follow-up) Add new cases introduced
It may fixes the crash, but not the behaviour. The parameter is authorised_value, not authorized_value.
There is also another occurrence in circ/branchtransfers.tt
Created attachment 113926 [details] [review] Bug 26819: (QA follow-up) authorized_value should be authorised_value
Created attachment 113927 [details] [review] Bug 26819: (QA follow-up) Fix branchtransfers.tt
*** Bug 27038 has been marked as a duplicate of this bug. ***
Created attachment 113978 [details] [review] Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 113979 [details] [review] Bug 26819: (QA follow-up) authorized_value should be authorised_value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 113980 [details] [review] Bug 26819: (QA follow-up) Fix branchtransfers.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected, passes the QA script. Sanity check is ok as well: $ git grep AuthorisedValues.GetDescriptionByKohaField | grep -v authorised_value => empty
Pushed to master for 20.11, thanks to everybody involved!
Missing dependencies, not backported for 20.05.x