On acquisitions home, 2 colons are displayed on the 'Pending suggestions' block. See screenshot : https://snipboard.io/nkLBJI.jpg.
Bug 25033 added library information to the counts of suggestions shown on the staff interface home page and the acquisitions home page. The LoginBranchname used in the template doesn't exist, having been removed by Bug 25765. The template should use [% Branches.GetLoggedInBranchname %] instead.
Created attachment 112576 [details] [review] Bug 26833: Logged in library doesn't show with suggestions count This patch corrects the template variables used by the suggestions counts shown on the staff interface home page and the acquisitions home page. They should use [% Branches.GetLoggedInBranchname %] To test you should have some suggestions from multiple libraries. - Log in to the staff interface. - On the home page you should see "Suggestions pending approval," followed by the name of your logged-in library and the count of suggestions for your library. - Go to the acquisitions page. - In the "Pending suggestions" section you should see the same information: Your logged-in library name, suggestion count, and the count of suggestions at all libraries.
Created attachment 112584 [details] [review] Bug 26833: Logged in library doesn't show with suggestions count This patch corrects the template variables used by the suggestions counts shown on the staff interface home page and the acquisitions home page. They should use [% Branches.GetLoggedInBranchname %] To test you should have some suggestions from multiple libraries. - Log in to the staff interface. - On the home page you should see "Suggestions pending approval," followed by the name of your logged-in library and the count of suggestions for your library. - Go to the acquisitions page. - In the "Pending suggestions" section you should see the same information: Your logged-in library name, suggestion count, and the count of suggestions at all libraries. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
I've got a slightly different display from what is described. Using 'independentbanches', a staff user sees only 'logged-in library: nb' on both pages while a superlibrarian sees 'logged-in library: nb / All libraries: nb'. Without 'independentbanches', the 2 informations for the 'logged-in library' and 'all librairies' are display including in the home page. I signed thought, because that's completely relevant and what I expected as display. Let me know if I shouldn't have to.
Created attachment 112800 [details] [review] Bug 26833: Logged in library doesn't show with suggestions count This patch corrects the template variables used by the suggestions counts shown on the staff interface home page and the acquisitions home page. They should use [% Branches.GetLoggedInBranchname %] To test you should have some suggestions from multiple libraries. - Log in to the staff interface. - On the home page you should see "Suggestions pending approval," followed by the name of your logged-in library and the count of suggestions for your library. - Go to the acquisitions page. - In the "Pending suggestions" section you should see the same information: Your logged-in library name, suggestion count, and the count of suggestions at all libraries. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
does not apply clean to 20.05.x, no backport