May libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start.
+1, this would be handy
Created attachment 112858 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well
Created attachment 112859 [details] [review] Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again
I've add a TODO for code dealing with "ccl=". I will create a follow-up
Created attachment 112913 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 112914 [details] [review] Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Can't test with Zebra, I only validate the very good behaviour with ES. Thanks Frido for this nice patch :)
Created attachment 112931 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 112932 [details] [review] Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment on attachment 112932 [details] [review] Bug 26860: Add without items facet Review of attachment 112932 [details] [review]: ----------------------------------------------------------------- ::: C4/Search.pm @@ +1322,4 @@ > } > $q .= ' and '.join(' and ', @limits) if @limits; > } > + #TODO withoutitems limit What is this TODO about?
(In reply to Fridolin SOMERS from comment #4) > I've add a TODO for code dealing with "ccl=". > I will create a follow-up Still waiting the follow-up then?
CCL part refers to : Bug 17278: Use available limit when requesting zebra when ccl query is used
Created attachment 113220 [details] [review] Bug 26860: (follow-up) case requesting zebra with ccl query When calling a ccl syntax query, code must be added like for availability facet. See Bug 17278: Use available limit when requesting zebra when ccl query is used This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne 'available' } @limits". Following the logic of : Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Test plan : 1) Use Zebra search engine 2) Perform a search on staff interface with explicit index, for example 'ti:history' 3) This search must return some records with and some without items 4) Click on 'Limit to records without items' 5) Check you see only records without items 6) Click on 'Show all records' 7) Check you see all records again 8) Check availability facet is also working
Created attachment 119112 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 119113 [details] [review] Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 119114 [details] [review] Bug 26860: (follow-up) case requesting zebra with ccl query When calling a ccl syntax query, code must be added like for availability facet. See Bug 17278: Use available limit when requesting zebra when ccl query is used This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne 'available' } @limits". Following the logic of : Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Test plan : 1) Use Zebra search engine 2) Perform a search on staff interface with explicit index, for example 'ti:history' 3) This search must return some records with and some without items 4) Click on 'Limit to records without items' 5) Check you see only records without items 6) Click on 'Show all records' 7) Check you see all records again 8) Check availability facet is also working Signed-off-by: David Nind <david@davidnind.com>
Created attachment 120994 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Enhancment not backported to 21.05.x
(In reply to Kyle M Hall from comment #17) > Created attachment 120994 [details] [review] [review] > Bug 26860: facets.inc refactor availability facet > Oh crap, only first patch has been QA and others set obsolete. So only first patch is in master : > git log --online --grep=26860 origin/master 63d6c1d8c5 Bug 26860: facets.inc refactor availability facet
The patch that has been pushed is now reverted. Please clarify the situation. Tests are missing anyway and the patches are not ready for integration into master.
Created attachment 124125 [details] [review] Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 124126 [details] [review] Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 124127 [details] [review] Bug 26860: (follow-up) case requesting zebra with ccl query When calling a ccl syntax query, code must be added like for availability facet. See Bug 17278: Use available limit when requesting zebra when ccl query is used This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne 'available' } @limits". Following the logic of : Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Test plan : 1) Use Zebra search engine 2) Perform a search on staff interface with explicit index, for example 'ti:history' 3) This search must return some records with and some without items 4) Click on 'Limit to records without items' 5) Check you see only records without items 6) Click on 'Show all records' 7) Check you see all records again 8) Check availability facet is also working Signed-off-by: David Nind <david@davidnind.com>
Maybe can now be implemented with Bug 17170
(In reply to Fridolin Somers from comment #25) > Maybe can now be implemented with Bug 17170 Yes it can :D