Bug 2688 - Z39.50 should report connection failures even if some succeeded
Summary: Z39.50 should report connection failures even if some succeeded
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-17 12:37 UTC by Nahuel Angelinetti
Modified: 2018-12-03 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch for HEAD (2.35 KB, patch)
2008-10-17 00:42 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for 3.0.x (2.34 KB, patch)
2008-10-17 00:43 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:54:43 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2008-10-17 00:37:04 ----

When you do a reserch via z39.50, the script does not warn the user it cannot connect to the z39.50 server.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-10-17 00:42:32 ----

Created an attachment
Patch for 3.0.x





---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-10-17 00:43:23 ----

Created an attachment
Patch for 3.0.x





---- Additional Comments From gmcharlt@gmail.com 2008-10-21 08:29:53 ----

Patch applied.  However, it could use improvement; if one searches two Z39.50 servers, one of which fails and the other one works, the user is not informed about the failure.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-10-07 12:31:12 ----

I didn't find this patch on HEAD, it wasn't applied.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:54 UTC  ---

This bug was previously known as _bug_ 2688 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2688
Imported an attachment (id=792)
Imported an attachment (id=793)

Actual time not defined. Setting to 0.0
The original submitter of attachment 792 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 793 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-07-02 19:00:07 UTC
This patch has been applied to HEAD--I see the changes in the current code and single failure or multiple failures are reported correctly. Galen is correct that if one of your searches is successful the interface will report no errors. I'm re-wording the bug so that this specific issue can still be addressed.
Comment 2 Marc Véron 2015-09-06 17:48:18 UTC
Is this bug still valid?

I tried a search with two invalid servers and a valid one. The results reported:


Connection failed to fjköfasjfjksa
Connection failed to sfdfsdfsd

...plus the results from the valid server.
Comment 3 Katrin Fischer 2018-05-16 00:18:25 UTC
I confirm, current versions of Koha report if one or more connections have failed.