On course_reserves/batch_add_items.pl and course_reserves/add_items.pl, we could use a little explanatory text about how things work with the new checkboxes. Maybe: “Checking the box next to the subfield label will enable changes to that subfield. Leave boxes unchecked to make no change.” Also, batch add has a message of: "Any items with existing course reserves will have their on reserve values updated." I assume this also applies to an item added singly? We should add that to the single item page.
Created attachment 112748 [details] [review] Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.<br> Any items with existing course reserves will have their on reserve values updated."
Created attachment 112749 [details] [review] Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.<br> Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 112750 [details] [review] Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.<br> Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Created attachment 112775 [details] [review] Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.<br> Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x