I believe this message was styled differently pre Bootstrap update and stood out a bit more visually. To test: - Create a new suggestion in the OPAC for a title named test. - Create another suggestion for "Test". - Verify the duplicate message shows and the suggestion is not saved: A similar document already exists: Test. Click on "Confirm your suggestion" to ignore this message.
Created attachment 112835 [details] [review] Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists."
Created attachment 112911 [details] [review] Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind <david@davidnind.com>
Testing note: - Need to updated the OPAC CSS - see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
Created attachment 112955 [details] [review] Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind <david@davidnind.com>
Pushed to master for 20.11, thanks to everybody involved!