To recreate: - set your SearchEngine to Elastic - have an authority record - stage and import it - use link from completed import to see authority and confirm it exists in your system - search for authority, confirm you cannot find it
Created attachment 113613 [details] [review] Bug 26903: Unit tests
Created attachment 113614 [details] [review] Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed
Created attachment 113644 [details] [review] Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com>
Created attachment 113645 [details] [review] Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 113664 [details] [review] Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 113665 [details] [review] Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, passing QA
Pushed to master for 20.11, thanks to everybody involved!
Doesn't apply cleanly to 20.05, please rebase
Created attachment 114299 [details] [review] Bug 26903: [20.05.x] Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
backported to 20.05.x for 20.05.07
index_records doesn't exist in 19.11 Missing dependencies for 19.11.x, can't backport.