I believe the removal of the syspref caused the plugins pulldown to no longer show on the edi vendor accounts editor.
Created attachment 112919 [details] [review] Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back!
Created attachment 112969 [details] [review] Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind <david@davidnind.com>
Testing notes - step 1: 1. Download one of the EDI plugins from https://github.com/bywatersolutions/koha-plugin-edifact-enhanced/releases (it doesn't matter which one). 2. Install the plugin (Koha administration > Plugins > Manage plugins > Upload plugin > browse for the plugin you downloaded in step 1 > click upload - the plugin will then show in the list of plugins). Note: Plugins need to be enabled for your development environment - make sure your plugin directory is set (KTD = <pluginsdir>/var/lib/koha/kohadev/plugins</pluginsdir>) and it is enabled (<enable_plugins>1</enable_plugins>) in the koha-conf.xml file for your instance.
I feel like instead of introducing a further call to set plugins_enabled and passing it to the template we should just check for the presence of the 'plugins' variable directly in the template instead. Thoughts?
Created attachment 113096 [details] [review] Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 113097 [details] [review] Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Minor tidy up followup added.. Works well, Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
I'm sure this depends on something but I don't know what. What syspref was removed? Is this needed for 19.11.x?
I am not sure if it's needed, but the pref was UsePlugins.
Thanks Katrin, I believe this probably depends on Bug 20415 then, so this patch isn't needed in 19.11.x. Not backported