Bug 2693 - Tagging: Add filter by name
Summary: Tagging: Add filter by name
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P3 enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 04:57 UTC by Nicole C. Engard
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot 1 (31.93 KB, image/png)
2008-10-20 04:58 UTC, Chris Cormack
Details
Screenshot 2 (56.40 KB, image/png)
2008-10-20 04:58 UTC, Chris Cormack
Details
Bug 2693 - Tagging: Add filter by name (3.27 KB, patch)
2013-08-21 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 2693 - Tagging: Add filter by name (3.25 KB, patch)
2013-09-18 12:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 2693 - Tagging: Add filter by name (3.16 KB, patch)
2013-10-20 18:01 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 2693 - Tagging: Add filter by name (4.10 KB, patch)
2013-10-22 17:16 UTC, David Cook
Details | Diff | Splinter Review
Bug 2693 - Tagging: Add filter by name (4.16 KB, patch)
2013-11-07 14:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:54:46 UTC


---- Reported by nengard@gmail.com 2008-10-20 04:57:51 ----

Tagging filters searches for borrownumber - but there is no staff member who's going to know the borrowernumber off hand - it should be name search [screenshot 1]

On another note - When searching for a borrowernumber - it stills give the same error and shows the results [screenshot 2]



---- Additional Comments From nengard@gmail.com 2008-10-20 04:58:08 ----

Created an attachment
screenshot 1





---- Additional Comments From nengard@gmail.com 2008-10-20 04:58:29 ----

Created an attachment
Screenshot 2





---- Additional Comments From joe.atzberger@liblime.com 2008-10-20 07:05:07 ----

Name search would be an enhancement.  



---- Additional Comments From nengard@gmail.com 2008-10-20 07:06:31 ----

Joe - but there is a bug too ... it's showing an error when you search by borrowernumber.



---- Additional Comments From oleonard@myacpl.org 2009-07-28 14:29:25 ----

I'm changing the name of this bug to focus on the enhancement aspect. I'll open another bug for the filter error.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:54 UTC  ---

This bug was previously known as _bug_ 2693 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2693
Imported an attachment (id=796)
Imported an attachment (id=797)

Actual time not defined. Setting to 0.0
CC member bchurch@ptfs.com does not have an account here
CC member joe.atzberger@liblime.com does not have an account here
The original submitter of attachment 796 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 797 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2013-08-21 14:59:57 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-09-18 09:52:38 UTC
Applying: Bug 2693 - Tagging: Add filter by name
Using index info to reconstruct a base tree...
M	circ/ysearch.pl
Falling back to patching base and 3-way merge...
Auto-merging circ/ysearch.pl
CONFLICT (content): Merge conflict in circ/ysearch.pl
Patch failed at 0001 Bug 2693 - Tagging: Add filter by name
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 3 Owen Leonard 2013-09-18 12:47:08 UTC Comment hidden (obsolete)
Comment 4 I'm just a bot 2013-09-29 06:09:44 UTC
Applying: Bug 2693 - Tagging: Add filter by name
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
Patch failed at 0001 Bug 2693 - Tagging: Add filter by name
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 5 Chris Cormack 2013-10-20 18:01:22 UTC Comment hidden (obsolete)
Comment 6 David Cook 2013-10-22 17:16:26 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-07 14:42:40 UTC
QA comment:

I reproduced the error described by David, but just one time. I don't think it is critical.
However, the autocomplete is often dependent on the CircAutocompl pref (request.tt, patron search header), but not always (patron list, course reserve).
Since we are not in the circulation module, maybe this pref should not be check. But I suppose this pref exists in order to avoid performance issue.

I am leaning towards to mark as passed QA this patch but I let the last word to the RM (as always, of course ;))
Comment 8 Jonathan Druart 2013-11-07 14:43:05 UTC
Created attachment 22780 [details] [review]
Bug 2693 - Tagging: Add filter by name

If you want to filter results on the tags management page by the
reviewer you have to know their borrowernumber. It would be better to be
able to search by name, but in the meantime this patch adds an
autocomplete widget to the form field so that you can do a name search
and populate the field with the borrowernumber.

To test you must have approved or rejected tags. From the tags review
page (tags/review.pl), view all, approved, or rejected tags. Type a name
in the "reviewer" form field in the left sidebar filter. You should get
an autocomplete dropdown with names matching your search. When you
select one the form field should be populated by the borrowernumber.

Signed-off-by: David Cook <dcook@prosentient.com.au>

Patch works as described. I'm not sure whether or not it would be better
to be able to search by name, as that would involve either choosing
between names after applying the filter or showing any possible matches,
so this seems fine.

--

Owen and I did observe that we were able to cause AJAX errors while
using this autocomplete, but we are not 100% sure how we caused the error.
In my case, I was able to occasionally cause it by typing in a name
then backspacing rapidly. The ajaxError method is attached to every
element in the DOM (yikes) so it's tough to say what exactly is the
source of the error (which is signalled by a pop-up window that can be
cancelled).

The error is quite rare so I don't think it's necessarily a problem
for us.

One idea that Owen had was to remove the current error message, which
is very unhelpful and replace it with an error like "Something went
wrong. Try again."

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Galen Charlton 2013-12-02 15:59:41 UTC
Pushed to master.  Thanks, Owen!
Comment 10 Fridolin Somers 2013-12-13 15:08:27 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1