To recreate: - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column We should show the actual display values here, rather than collapsing all positive values into "not for loan" and all negative values into "on order."
Created attachment 113429 [details] [review] Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description
Created attachment 114105 [details] [review] Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 115183 [details] [review] Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu>
Hi Lucas, a little glitch here: Before every status was on a new line (display:block), now it's inside a new span with a different class, this no longer works and all the status appear on one line which can make the column cell go wide pretty fast. Can you please fix?
Created attachment 115376 [details] [review] Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu>
Cait, I see what you mean, to fix it I have simply done same thing as the unavailable right above the notforloan one, I added a <br />. Since its a little change I am keeping Andrew and Telishia's SO lines.
Created attachment 116474 [details] [review] Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Telishia Mickens <tmickens@gc.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx, Lucas, sorry it took me a while to get back to this.
We are "loosing" 2 wordings that are no longer translatable, but I think it's fine.
(In reply to Jonathan Druart from comment #9) > We are "loosing" 2 wordings that are no longer translatable, but I think > it's fine. We already do this in the normal serach result lists... so I guess it's consistent.
Pushed to master for 21.05, thanks to everybody involved!
Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.