If a library is using the streetnumber field, it does not show the streetnumber field in the patronautocomplete feature.
This is still an issue in master.
Created attachment 147480 [details] [review] Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed.
Created attachment 147512 [details] [review] Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Works like a charm!
There are some issues: To test I edited my user (42) and filled in the fields with the field names and different numbers for zipcode and streetnumber, to be able to identify what field is which. 1) * Address format US * Missing space between address 2 and city 2) * Address format German * Address 2 is missing completely * Missing space between streetnumber and zipcode 3) * Address format French * completely broken :( Spinning icon is visible and error in the console: * Uncaught ReferenceError: include_li is not defined 4) The bug description should be rephrased, this adds more than the streetnumber.
Created attachment 147818 [details] [review] Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed.
Created attachment 148498 [details] [review] Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 149376 [details] [review] Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport.