Bug 26994 - Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management
Summary: Display list of names in alphabetical order when using the Suggestion informa...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Shi Yao Wang
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-10 16:43 UTC by Barbara Johnson
Modified: 2023-11-28 13:39 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12


Attachments
Bug 26994: List names in alphabetical order in Suggestion filter (1.27 KB, patch)
2023-07-26 17:12 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 26994: List names in alphabetical order in Suggestion filter (1.32 KB, patch)
2023-08-04 19:47 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 26994: List names in alphabetical order in Suggestion filter (1.38 KB, patch)
2023-10-07 21:54 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara Johnson 2020-11-10 16:43:10 UTC
In Suggestions Management when filtering searches using the Suggestion Information filter and then using the 'Suggested by', 'Managed by' or 'Accepted by' dropdowns it would be helpful if the list of names was displayed in alphabetical order.
Comment 1 George Williams (NEKLS) 2021-05-20 17:38:33 UTC
It would be nice if this was addressed.
Comment 2 Marie-Luce Laflamme 2023-07-25 14:52:14 UTC
It's not easy to search names within the 'Managed by', 'Accepted by' and 'Suggested by' drop-down menus. Koha seems to order names by suggestion's date added instead of displaying them in names alphabetical order.

It would be nice to fix this.


Test plan

1. Add different purchase suggestions from various patron's names
2. Go to Acquisition > Suggestions
3. Click on the Suggestion information filters on the left-hand side
4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by"
--> notice the list of names in menus, names aren't displayed from A to Z
Comment 3 Shi Yao Wang 2023-07-26 17:12:49 UTC
Created attachment 153934 [details] [review]
Bug 26994: List names in alphabetical order in Suggestion filter

Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

Test plan:
1. Add different purchase suggestions from various patron's names
2. Go to Acquisition > Suggestions
3. Click on the Suggestion information filters on the left-hand side
4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by"
--> notice the list of names in menus, names aren't displayed from A to Z
5. Apply patch and refresh page
6. Redo step 4
--> notice now it's sorted alphabetically
Comment 4 ByWater Sandboxes 2023-08-04 19:47:45 UTC
Created attachment 154296 [details] [review]
Bug 26994: List names in alphabetical order in Suggestion filter

Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

Test plan:
1. Add different purchase suggestions from various patron's names
2. Go to Acquisition > Suggestions
3. Click on the Suggestion information filters on the left-hand side
4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by"
--> notice the list of names in menus, names aren't displayed from A to Z
5. Apply patch and refresh page
6. Redo step 4
--> notice now it's sorted alphabetically

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Comment 5 Victor Grousset/tuxayo 2023-10-07 21:54:05 UTC
Created attachment 156703 [details] [review]
Bug 26994: List names in alphabetical order in Suggestion filter

Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

Test plan:
1. Add different purchase suggestions from various patron's names
2. Go to Acquisition > Suggestions
3. Click on the Suggestion information filters on the left-hand side
4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by"
--> notice the list of names in menus, names aren't displayed from A to Z
5. Apply patch and refresh page
6. Redo step 4
--> notice now it's sorted alphabetically

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-10-07 21:54:43 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Tomás Cohen Arazi 2023-10-20 19:31:59 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-26 06:15:27 UTC
Very easy enhancement, I choose to backport.

Pushed to 23.05.x for 23.05.05
Comment 9 Matt Blenkinsop 2023-11-13 14:19:47 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x