Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications It will need to be removed from many of the same places as "guarantorid" from Bug 14570 like: - C4/Auth_with_ldap - C4/SIP/ILS/Patron.pm - Possibly other places...
Created attachment 115532 [details] [review] Bug 26995: Drop columns from database
Created attachment 115533 [details] [review] Bug 26995: Remove references to relationship column
Created attachment 115534 [details] [review] Bug 26995: Update schema [DO NOT PUSH]
Created attachment 115537 [details] [review] Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications
Created attachment 115538 [details] [review] Bug 26995: Remove references to relationship column
Created attachment 115539 [details] [review] Bug 26995: Update schema [DO NOT PUSH]
Not sure how to write a test plan for this.
Created attachment 120399 [details] [review] Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications
Created attachment 120400 [details] [review] Bug 26995: Remove references to relationship column
Created attachment 120451 [details] [review] Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 120452 [details] [review] Bug 26995: Remove references to relationship column Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 120453 [details] [review] Bug 26995: (QA follow-up) Fix logic in database update The logic was reversed.. if the column exists we want to delete it ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Not sure what happened with this one.. there are patches uploaded by Jonathan but no signoff lines from him and the author suggests Kyle. Either way, it works as expected with my follow-up. Signing off.
(In reply to Martin Renvoize from comment #13) > Not sure what happened with this one.. there are patches uploaded by > Jonathan but no signoff lines from him and the author suggests Kyle. I've only rebased the patch yesterday.
Created attachment 120744 [details] [review] Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120745 [details] [review] Bug 26995: Remove references to relationship column Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120746 [details] [review] Bug 26995: (QA follow-up) Fix logic in database update The logic was reversed.. if the column exists we want to delete it ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120775 [details] [review] Bug 26995: Fix SQL syntax error on the about page
Created attachment 120793 [details] [review] Bug 26995: Remove occurrences in sample_patrons.yml
Pushed to master for 21.05, thanks to everybody involved!
Created attachment 120826 [details] [review] Bug 26995: Remove one remaining occurrence in moremember
Follow-up pushed to master.
I propose we do not push to stable branches.
Uh oh, we've introduced a regression here with data loss... It turns out we still needed the "relationship" column for "Non-patron guarantor" entries. It means you can't save patron records that need guarantors because the form can't be processed. And anyone who applies 21.05 will lose the data that they had in borrowers.relationship...
(In reply to David Cook from comment #24) > Uh oh, we've introduced a regression here with data loss... > > It turns out we still needed the "relationship" column for "Non-patron > guarantor" entries. > > It means you can't save patron records that need guarantors because the form > can't be processed. > > And anyone who applies 21.05 will lose the data that they had in > borrowers.relationship... Ah, just noticed bug 28490. People are already on top of this.
NewVersion( $DBversion, 26995, "[SKIP] Drop column relationship from borrower tables [not executed]"); Printing this made me wonder what happened ;) Print nothing, no concerns..