test plan: [1] Log in to Opac [2] Go to your purchase suggestions menu [3] Create purchase suggestions Ex. "title: harry potter" [4] Go to purchase suggestions menu [5] Type "harry potter" In <search for> field [6] The search result is not show only "harry potter" but show all purchase suggestions list.
This works for me in master, 20.11 and 20.05.. Can you clarify by stating your version and exact steps to replicate.
I can reproduce this in master... Submitting a search doesn't change the list of suggestions at all. I think it may have been broken since 19.11.x.
(In reply to Owen Leonard from comment #2) > I can reproduce this in master... Submitting a search doesn't change the > list of suggestions at all. I think it may have been broken since 19.11.x. Hum.. I must be looking in entirely the wrong place then..
Doh!.. OPAC
Tracing back, I can't see when this was broken.. but also can't see how it worked in the past.. it looks like it submits a form back and expects a full page reload.. except there's nothing in the controller to action that form submission. I'd propose just switching to DataTables filtering..
Created attachment 115189 [details] [review] Bug 27047: Fix suggestions filtering at the OPAC There is a "Search" input box that appears to be broken for... ever? This patch replaces it with the DataTables filtering. Test plan: Create some suggestions, go to your suggestion list at the OPAC Confirm that the filtering now works correctly
Created attachment 115211 [details] [review] Bug 27047: Fix suggestions filtering at the OPAC There is a "Search" input box that appears to be broken for... ever? This patch replaces it with the DataTables filtering. Test plan: Create some suggestions, go to your suggestion list at the OPAC Confirm that the filtering now works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 115222 [details] [review] Bug 27047: Fix suggestions filtering at the OPAC There is a "Search" input box that appears to be broken for... ever? This patch replaces it with the DataTables filtering. Test plan: Create some suggestions, go to your suggestion list at the OPAC Confirm that the filtering now works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.02
Doesn't apply cleanly to 20.05.x, please rebase if needed.
I reintroduced this filter on bug 26406.