The conversion of OPAC templates to Bootstrap 4 included the introduction of automatic generation of right-to-left CSS using rtlcss(). This process unintentionally results in the creation of an RTL version of staff-global.css although it is unused. The ultimate goal should be to update the staff interface to include RTL CSS generated by rtlcss, but in the meantime we can make a change to gulpfile.js to exclude the staff client CSS from processing.
I'd like this one for 20.11 if possible.
Created attachment 113925 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions.
Created attachment 113938 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 113950 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thank, Owen!
Created attachment 113951 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Ohh, we clashed.. I was just QAing too.. double signoff :)
Pushed to master for 20.11, thanks to everybody involved!
Missing dependency, not backported to 20.05