Bug 27081 - Notes missing from lost items report column configuration when CSV export is active
Summary: Notes missing from lost items report column configuration when CSV export is ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-23 16:25 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 27081: Handle first column (checkboxes) in column settings for lost items report (1.70 KB, patch)
2022-08-10 14:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27081: Handle first column (checkboxes) in column settings for lost items report (1.76 KB, patch)
2022-08-21 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 27081: Handle first column (checkboxes) in column settings for lost items report (1.81 KB, patch)
2022-09-02 15:27 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-11-23 16:25:52 UTC
The last column of the lost items report - "notes" is missing from the table configuration pull down in 20.05.05. Couldn't test in master yet.
Comment 1 Jonathan Druart 2020-11-24 10:58:48 UTC
Ok on master.
Comment 2 Katrin Fischer 2020-11-24 12:07:01 UTC
Thx for checking!
Comment 3 Katrin Fischer 2021-06-02 16:35:27 UTC
This is ok in 21.05 as well, but in 20.11.06 the last entry in the pull down is 'not for loan', notes is missing there.
Comment 4 Katrin Fischer 2021-07-14 10:19:13 UTC
I figured it out: The problem is only visible when a CSV profile for the lost items report has been defined.

When you do this an additional first row with checkboxes appears that sets the column configuration off by one and the "notes" disappear as last option from the columns list.
Comment 5 Katrin Fischer 2022-07-16 11:46:31 UTC
Still valid on master.

To test:
* Create a CSV profile of type SQL for exporting lost items
* Make sure you have some lost items
* Run Reports > Items lost
* Verify the list of columns ends with 'not for loan status', note is missing
Comment 6 Jonathan Druart 2022-08-10 14:38:56 UTC
Created attachment 139001 [details] [review]
Bug 27081: Handle first column (checkboxes) in column settings for lost items report

We are adding one column (the one with the checkboxes) at the beginning
of each row if it's possible to export the report to CSV.
However the column settings were not modified. We need to append one
object representing this column.

Test plan:
To test:
* Create a CSV profile of type SQL for exporting lost items
* Make sure you have some lost items
* Run Reports > Items lost
=> You can hide the notes (last column)
Comment 7 Jonathan Druart 2022-08-10 14:39:22 UTC
Sorry, I didn't test correctly. This patch should fix the problem.
Comment 8 Jonathan Druart 2022-08-10 14:46:32 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2022-08-21 21:42:56 UTC
Created attachment 139561 [details] [review]
Bug 27081: Handle first column (checkboxes) in column settings for lost items report

We are adding one column (the one with the checkboxes) at the beginning
of each row if it's possible to export the report to CSV.
However the column settings were not modified. We need to append one
object representing this column.

Test plan:
To test:
* Create a CSV profile of type SQL for exporting lost items
* Make sure you have some lost items
* Run Reports > Items lost
=> You can hide the notes (last column)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Kyle M Hall 2022-09-02 15:27:38 UTC
Created attachment 140161 [details] [review]
Bug 27081: Handle first column (checkboxes) in column settings for lost items report

We are adding one column (the one with the checkboxes) at the beginning
of each row if it's possible to export the report to CSV.
However the column settings were not modified. We need to append one
object representing this column.

Test plan:
To test:
* Create a CSV profile of type SQL for exporting lost items
* Make sure you have some lost items
* Run Reports > Items lost
=> You can hide the notes (last column)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Tomás Cohen Arazi 2022-09-07 20:30:36 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Lucas Gass 2022-10-31 19:44:09 UTC
Cannot recreate in 22.05.x, no backport