Bug 2712 - Invalid 3rd party content ( eg Amazon ) can break page layout
Summary: Invalid 3rd party content ( eg Amazon ) can break page layout
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P3 minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on: 5568
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-23 08:02 UTC by Chris Cormack
Modified: 2012-10-26 00:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:55:00 UTC


---- Reported by rch@liblime.com 2008-10-23 08:02:10 ----

example as of 2008-10-23:
isbn: 037582670X
title: Eldest

Amazon reviews has bad markup in it that breaks Koha's page layouts in both the
opac and staff interfaces.
The effect is that left navigation and right  columns get swallowed by the 'Descriptions' tab, and are thus only shown at the bottom of the page when that tab is visible.

Is there a way to prevent this from happening ?



---- Additional Comments From rch@liblime.com 2008-10-23 08:45:45 ----


http://public-staff.demo.kohalibrary.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=169917

http://public.demo.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=169917



---- Additional Comments From oleonard@myacpl.org 2008-10-24 07:59:27 ----

This is a toughie. The problem in this particular case is a few unclosed <div> tags. This case could be solved by adding some closing <div>s, but you never really know what kind of junk is going to come from Amazon.

We don't want to strip out all formatting from the Amazon content, because it would become unreadable. The only other thing I can think of is to use some kind of Tidy module to clean up the data before it gets output.



---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:39 ----

This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate.



---- Additional Comments From oleonard@myacpl.org 2009-12-28 16:04:28 ----

Still a valid bug, although it happens fairly rarely. I haven't heard any good suggestions for solving the problem.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:55 UTC  ---

This bug was previously known as _bug_ 2712 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2712

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was rch@liblime.com.

Comment 1 Katrin Fischer 2012-04-02 06:52:59 UTC
I am closing this bug as WONTFIX (see related bug 5568).