Bug 11529 added this change to cataloguing/moveitem.pl my $biblio = Koha::Biblios->find( $biblionumber ); -$template->param(bibliotitle => $biblio->title); +$template->param(biblio => $biblio); But the template was not updated so it still tries to access the bibliotitle variable <div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle | html %]</i></a>. Which no longer exists. So when the item is successfully moved, no biblio title is shown. This bug exists in 19.11 and 20.05 but not 20.11.
Created attachment 114128 [details] [review] Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology
Created attachment 114144 [details] [review] Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 114148 [details] [review] Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Sending to 20.05 RM queue.
Pushed to 20.05.x for 20.05.08
Backported: Pushed to 19.11.x branch for 19.11.14