On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { We should remove the whole Koha/Util/SystemPreferences.pm package.
Created attachment 116385 [details] [review] Bug 27154: Remove Koha::Util::SystemPreferences On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm We only need the one from Koha::Config::SysPref and remove the whole Koha::Util::SystemPreferences module. Test plan: prove t/db_dependent/Circulation/issue.t must return green
Created attachment 116386 [details] [review] Bug 27154: Remove Koha::Util::SystemPreferences On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm We only need the one from Koha::Config::SysPref and remove the whole Koha::Util::SystemPreferences module. Test plan: prove t/db_dependent/Circulation/issue.t must return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 116471 [details] [review] Bug 27154: Remove Koha::Util::SystemPreferences On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm We only need the one from Koha::Config::SysPref and remove the whole Koha::Util::SystemPreferences module. Test plan: prove t/db_dependent/Circulation/issue.t must return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Created attachment 116539 [details] [review] Bug 27154: Fix test if the cache is populated already
(In reply to Jonathan Druart from comment #5) > Created attachment 116539 [details] [review] [review] > Bug 27154: Fix test if the cache is populated already Patch pushed to master.
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.