The error is displayed (when it must be hidden): "An error occurred, please try again." and clicking the "Search" button does not do anything. Caused by commit 9cb89b46397efc5e288723829613c33e7eea0d69 Bug 20168: Update of the OPAC bootstrap template to bootstrap v4
Created attachment 114324 [details] [review] Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168
This patch fixes the original issue, but screen still does not look very nice.
Confirming that Jonathan's patch has restored the ability to search. However, the error statement is still visible and there are some css adjustments necessary as indicated. To address these, I've simply added the following to OpacUserCSS until they can be patched in a subsequent Koha version: #browse-search .error {display: none;} #browse-search #browse-selection {padding-top: 15px;} #browse-search #browse-searchresults, #browse-search #browse-selectionsearch {border: none;} Thank you to all!
Created attachment 114462 [details] [review] Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear.
Created attachment 114500 [details] [review] Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 114501 [details] [review] Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 114566 [details] [review] Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 114567 [details] [review] Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.01
Missing dependencies, not backported to 20.05