Hi, HTML output is fine but there's a lot of spaces in exported file, remove some. Moreover 12502 add a noExport attribute, use it in basket.tt Test plan: 1 - Create a basket. 2 - Export it in excel. 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file. 6 - It's tidier, fewer spaces and no Add/edit note.
Created attachment 114408 [details] [review] Bug 2740: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links
Created attachment 119105 [details] [review] Bug 2740: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links https://bugs.koha-community.org/show_bug.cgi?id=27240 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
No more useless notes informations, and less spaces so works fine for me. I just noticed a typo in the patch number (2740 instead of 27240), but I don't know how to correct that. Thank you Didier !
Created attachment 119825 [details] [review] Bug 27240: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links https://bugs.koha-community.org/show_bug.cgi?id=27240 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Séverine Queune from comment #3) > I just noticed a typo in the patch number (2740 instead of 27240), but I > don't know how to correct that. Thanks for noting it - I fixed the bug number in QA :)
There are much more to tidy, but let's call it a first step.
noExport must be on the th, like: <th class="noExport">Actions</th>
No, it's correct - we only want to add the link here, not the column!
(In reply to Katrin Fischer from comment #8) > No, it's correct - we only want to add the link here, not the column! add should read 'hide'!
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x