Since 20.11.00 and bug 27070 we dropped the support for ES5. We should add a warning on the about page.
Created attachment 114466 [details] [review] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages
Shouldn't we turn the feature on for master and 20.11?
It's seems that all the CI jobs are using ES6 so the tests should fail with this off by default. prove -r t/Koha/SearchEngine/Elasticsearch* t/db_dependent/Koha_Elasticsearch.t t/Koha_SearchEngine_Elasticsearch_Browse.t t/db_dependent/Koha/SearchEngine/ It turns out not :o
Bug 27070 did not add tests so I don't know which tests would be supposed to fail.
I thought searching with ES6 would be broken by default. And thus that some tests would fail. Because the syspref would allow to choose to have ES 6 working or ES 5 working and would default to ES 5.
(In reply to Victor Grousset/tuxayo from comment #5) > I thought searching with ES6 would be broken by default. And thus that some > tests would fail. Because the syspref would allow to choose to have ES 6 > working or ES 5 working and would default to ES 5. After bug 27070 ES5 searching was broken. This patch retores the ability to use ES5 - since Jenkins was using 6 everywhere, there was no problem
Alright, I missed «with ES6 - searching should "work" with either pref setting» Thanks for the explanations.
Created attachment 114553 [details] [review] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Nice changes thanks :) Should it be recommended to enable ElasticsearchCrossFields when using ES 6? To not have bug 27070
(In reply to Victor Grousset/tuxayo from comment #9) > Should it be recommended to enable ElasticsearchCrossFields when using ES 6? > To not have bug 27070 Yes, see comment 2. I think it should be turned on by default. Nick, what do you think?
Created attachment 114672 [details] [review] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 114673 [details] [review] Bug 27252: [20.05 and earlier] Default to cross fields off
(In reply to Jonathan Druart from comment #2) > Shouldn't we turn the feature on for master and 20.11? Yes, amended patch and attached followup for earlier versions
Created attachment 114878 [details] [review] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 114881 [details] [review] [20.05 and earlier] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 114882 [details] [review] [20.05 and earlier] Bug 27252: Default to cross fields off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.02
Pushed to 20.05.x for 20.05.07
Backported: Pushed to 19.11.x branch for 19.11.14 After some testing, the syspref has the expected effect with ES 5 and 6 However I can't see the deprecation warning. With ES 5 and syspref SearchEngine = elasticsearch, the about page shows "Version: 5.6.16" but no warning in the System information tab.
No warning in 20.05.x either but the warning is here in 20.11
(In reply to Victor Grousset/tuxayo from comment #21) > No warning in 20.05.x either but the warning is here in 20.11 You need bug 19542.
We have the commits in 19.11.x and 20.05.x , since 18.05. The ES version info is here in the "Server information" tab of the about page.