I have a couple of minor updates for the point of sale page: - buttons inside tables should use "btn-xs" to be a consistent size - required fields in the "Collect payment" form should be styled as required
Created attachment 114557 [details] [review] Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input.
Created attachment 114756 [details] [review] Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Seems we were working on similar things around the same time.. Thanks for the fixes here.. they look good.. Signing off.
I have a small issue here: The "required" fields now trigger their warning as soon as you add an item to the tab and before "Confirm" is hit cluttering up the page some. Could we move the check to trigger once you try to confirm?
Bug 27289 should certainly come into play for the above I think... are you happy to continue here Owen?
(In reply to Katrin Fischer from comment #4) > I have a small issue here: The "required" fields now trigger their warning > as soon as you add an item to the tab and before "Confirm" is hit cluttering > up the page some. Could we move the check to trigger once you try to confirm? This has always triggered.. I just double checked against master.. that changes here don't affect this.
Created attachment 116387 [details] [review] Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 116388 [details] [review] Bug 27289: (follow-up) Update payment type too. The payment type field is also required when using cash registers, this patch updates the formatting to work as expected in that case too.
I've added a follow-up to also set the proper display for payment type, which is also a required field. As for the validation, it is dealt with in the blocked bug.. I now remove the call to valid as requested here.. but do it when handling other validation issues in that pre-existing bug.
I just feel that: This field is required. Required is a little much to see it all the time :) The doubled up text has not been present before this patch and I think is what Owen was contemplating on bug 27427 that we should try to move forward.
Created attachment 116469 [details] [review] Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 116470 [details] [review] Bug 27289: (follow-up) Update payment type too. The payment type field is also required when using cash registers, this patch updates the formatting to work as expected in that case too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hm, looking at this on master again - payment type is required, but cannot be unset.. so do we need to mark it in red?
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03 In odrer to push Bug 27290
Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290
(In reply to Andrew Fuerste-Henry from comment #16) > Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290 Hmm, Not sure it's required to go back that far?