To reproduce: - View a patron who has resolved claims, either the checkout page or the patron detail page. - From the claim's "Action" menu, choose "Delete" - In the browser console you will see an error: Uncaught ReferenceError: issuesTable is not defined The claim is deleted, but the action is supposed to trigger a refresh of the checkouts table. Because "issueTable" is defined within a different function it can't be referenced here.
Created attachment 114605 [details] [review] Bug 27294: Error when deleting claim This patch corrects an error which occurs when deleting a claim from the claims tab on the checkout or patron detail page. To test, apply the patch and clear your browser cache if necessary. - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - Under the "Claims" tab, resolve one or more of the unresolved claims by choosing "Resolve" under the corresponding "Actions" menu. - Open the same "Actions" menu again and choose "Delete." - The claim should be deleted and there should be no error in the browser console. - Under the checkouts tab, the table should have refreshed so that the item which had been marked as "Claimed returned" no longer indicates an outstanding claim.
Created attachment 114606 [details] [review] Bug 27294: Error when deleting claim This patch corrects an error which occurs when deleting a claim from the claims tab on the checkout or patron detail page. To test, apply the patch and clear your browser cache if necessary. - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - Under the "Claims" tab, resolve one or more of the unresolved claims by choosing "Resolve" under the corresponding "Actions" menu. - Open the same "Actions" menu again and choose "Delete." - The claim should be deleted and there should be no error in the browser console. - Under the checkouts tab, the table should have refreshed so that the item which had been marked as "Claimed returned" no longer indicates an outstanding claim.
Created attachment 115318 [details] [review] Bug 27294: Error when deleting claim This patch corrects an error which occurs when deleting a claim from the claims tab on the checkout or patron detail page. To test, apply the patch and clear your browser cache if necessary. - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - Under the "Claims" tab, resolve one or more of the unresolved claims by choosing "Resolve" under the corresponding "Actions" menu. - Open the same "Actions" menu again and choose "Delete." - The claim should be deleted and there should be no error in the browser console. - Under the checkouts tab, the table should have refreshed so that the item which had been marked as "Claimed returned" no longer indicates an outstanding claim. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described.
Hi Owen, I have trouble replicating the bug without the patch. What I do: - Check out item - Claim returned - Resolve - Delete - The issue disappears from the claims list. Watching the console the whole time, there were no errors or warns related to these actions. Can you please double check on current master?
(In reply to Katrin Fischer from comment #5) > - Claim returned > - Resolve I think after this step you have to navigate away from the page or refresh the page for the error to occur.
I am sorry, still failing to see the error :( I will leave at signed off - I think another set of eyes is what is needed here.
I feel like this should be treated similarly to the claims table with load and refresh functions and a global scoped variable. Whilst the fix here, I think resolves this issue, I think there are other issues in the same script that appear to have the same underlying code issue.