Bug 17364 added the ability to exclude database columns in system preferences. When something is disabled the checkbox is disabled but it is still hard to tell its disabled because the corresponding label remains the same color as all the others.
Created attachment 114761 [details] [review] Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc)
Created attachment 114763 [details] [review] Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Oh style inside HTML :/ In my opinion it whould be better into CSS file. With selector : .dbcolumn_selection:disabled
(In reply to Fridolin Somers from comment #3) > Oh style inside HTML :/ > > In my opinion it whould be better into CSS file. > With selector : .dbcolumn_selection:disabled .dbcolumn_selection:disabled will style the disabled input but not it's parent, the label. In my opinion we want to be able to make the label have a gray color (#cccccc) Since CSS cannot target an element's parent I chose to style inline.
(In reply to Lucas Gass from comment #4) > (In reply to Fridolin Somers from comment #3) > > Oh style inside HTML :/ > > > > In my opinion it whould be better into CSS file. > > With selector : .dbcolumn_selection:disabled > > .dbcolumn_selection:disabled will style the disabled input but not it's > parent, the label. In my opinion we want to be able to make the label have a > gray color (#cccccc) > > Since CSS cannot target an element's parent I chose to style inline. Oooo indeed my mistake :O Thanks a lot for the explanation.
Created attachment 115045 [details] [review] Bug 27321: (follow-up) Use class instead of style attribute. This patch relplaces the inline style and uses a class name instead. SCSS is modified, so rebuild the staff client CSS before testing (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Can we please get a quick sign-off here so I can move on with the dependent bug? :)
(In reply to Owen Leonard from comment #6) > Created attachment 115045 [details] [review] [review] > Bug 27321: (follow-up) Use class instead of style attribute. > > This patch relplaces the inline style and uses a class name instead. > SCSS is modified, so rebuild the staff client CSS before testing > (https://wiki.koha-community.org/wiki/ > Working_with_SCSS_in_the_OPAC_and_staff_client). Owen, this is a much smarter way to do it than with the inline style I was using. However there is one problem. If I apply this and look at borrowerUnwantedField the disabled class is applied to 'branchcode' but it is also applied to every subsequent db column. I think in the else block we need tell it which class to have.
Created attachment 115103 [details] [review] Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc)
Created attachment 116088 [details] [review] Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: David Nind <david@davidnind.com>
I had trouble getting this patch to apply with the dependencies, but managed to git there in the end: - git bz apply 17364 - git bz apply 27321 (git bz apply 27321 - Bug 27321 Depends on bug 27261 Follow? [(y)es, (n)o] y) If I just went git bz apply 27321 and said yes to dependent bugs (only 27261) then it wouldn't apply. In the test plan I'm assuming BorroweUnwantedFields should be PatronSelfRegistrationBorrowerUnwantedField
Created attachment 116118 [details] [review] Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Updating this to a bug fix as I think we should not push the dependent bugs without this final style fix.
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Missing dependency, not backporting to 20.05