By using Koha.Preference() in the templates everywhere, we can remove the variable from Auth.pm in the end. After bug 27031, it looks like the remaining instances are: C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% IF ( virtualshelves && intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% ELSIF ( intranetbookbag ) %]
Sounds good to me
Created attachment 115287 [details] [review] Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change
We can then remove the 2 following occurrences: C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"),
Created attachment 115336 [details] [review] Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 115337 [details] [review] Bug 27324: (follow-up) Remove references to intranetbookbag from Auth.pm This patch removes references to intranetbookbag from Auth.pm. Now that the templates use Koha.Preference("intranetbookbag") everywhere it is unnecessary.
Created attachment 115339 [details] [review] Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 115340 [details] [review] Bug 27324: (follow-up) Remove references to intranetbookbag from Auth.pm This patch removes references to intranetbookbag from Auth.pm. Now that the templates use Koha.Preference("intranetbookbag") everywhere it is unnecessary. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, no regressions. Thanks for your contribution Mazen, welcome to Koha :) Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Does not apply en 20.11.x because of Bug 26707 Not pushed to 20.11.x. It is a small plumbing change so I think there is no need to create a rebased patch.