There are some markup inconsistencies in admin/branches.tt which should be cleaned up, and system preference references should be linked directly to the preference (with permission)
Created attachment 115181 [details] [review] Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission.
Created attachment 115251 [details] [review] Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com>
Created attachment 115263 [details] [review] Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx again, Mazen!
Created attachment 115415 [details] [review] Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: - <br /><span class="hint"> changed to <div class="hint"> - References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: Add missing space to correctly align input with label
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x