There are some markup inconsistencies in admin/patron-attr-types.tt which should be cleaned up, and system preference references should be linked directly to the preference (with permission)
Created attachment 115182 [details] [review] Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission.
Created attachment 115255 [details] [review] Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. Signed-off-by: Victoria Faafia <vfaafia29@gmail.com>
Created attachment 115258 [details] [review] Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic <span>s to <div class="hint"> - Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. Signed-off-by: Victoria Faafia <vfaafia29@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx for testing, Victoria!
Owen, shouldn't we remove the "Authorized value category;" part from "Authorized value category; if one is selected, the patron record input page will only allow values to be chosen from the authorized value list. However, an authorized value list is not enforced during batch patron import."? https://snipboard.io/u5vmDB.jpg
Created attachment 115429 [details] [review] Bug 27439: Remove repetition in hint
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x