While working on a separate issue I notices there are several markup errors in suggestion/suggestion.tt. 1. <h2> tag closes with an </h3> 2. Some button elements are using the self-closing syntax when they should not 3. <div id="limits> does not close 4. There are some stray </div>'s 5. Indentation/white could be better
Created attachment 115774 [details] [review] Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab.
Created attachment 115792 [details] [review] Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind <david@davidnind.com>
I tested on Firefox and Google Chrome (latest versions) on Ubuntu 18.04. Everything seemed to work fine, with the caveat that I'm not that familiar with suggestions. I did check the page with WebAIM's WAVE toolbar, however I think the potential issues it identifies are a separate project (for the whole of Koha).
Created attachment 115840 [details] [review] Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115841 [details] [review] Bug 27446: (QA follow-up) Add missing filters
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Doesn't apply cleanly to 20.05. Please rebase if needed.