This is a bit irritating and makes it a little harder when you want to fill out the form quickly. To test: - Create 2 PA_CLASS values and an empty one - Create 3 patron attributes, one for each (I had A, B and the preinstalled SHOW_BCODE) - Open any patron form for editing - Note sequence of additional attributes - Reload page - Verify the sequence changes with reloads
I noticed this.. it's due to hash order randomisation I believe.. pretty sure I identified where it could be fixed.. will take a look on Monday
Created attachment 115238 [details] [review] Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff
Created attachment 116244 [details] Bug 27454 - Display of paytron attributes after apply patch Hi Martin. I could replicate the problem, but after applying the patch the display of the additional attributes goes really weird - see screenshot. I created three patron attrributes: PA0, PA1, and PA2. I flushed the cached and restarted all after applying the patch. David
Created attachment 116254 [details] [review] Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :)
Created attachment 116291 [details] [review] Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff Signed-off-by: David Nind <david@davidnind.com>
Created attachment 116292 [details] [review] Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :) Signed-off-by: David Nind <david@davidnind.com>
Oops, thanks for the fix Jonathan.
Created attachment 116461 [details] [review] Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 116462 [details] [review] Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.