When creating a new credit type in administration, it would be nice if the cursor was in the first form field "Credit type code ". See bug 27192 for a similar one.
Created attachment 115276 [details] [review] Bug 27458 Focus cursor to credit type code when creating new type. Test plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field. 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credit type code field.
Hi Amy, thanks for your patch! The commit message must start with "Bug 27458: ". Can you resubmit please?
Created attachment 115344 [details] [review] Bug 27458: Sets cursor to focus credit type code when creating new type. Test plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field. 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credit type code field.
Hi Amy, could you take a look at the bug linked in the first comment? The solution there is a little different using a class="focus" to the input element. I think that would be a more standardized way of doing this! There are also 2 patches here currently, you can obsolete them by going on details > edit details > obsolete or by using git bz. :)
Created attachment 115377 [details] [review] Bug 27458: cursor focueses to credit type field using class="focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note hoe the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field
I have tried this twice and am not seeing the cursor automatically placed in the credit type code field.
There is already a class attribute on that <input> tag, so the new "focus" value should be added to it, e.g. 'class="required focus"'
Created attachment 115459 [details] [review] Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field
Created attachment 115468 [details] [review] Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
It works!
Created attachment 115522 [details] [review] Bug 27458: cursor focueses to credit type field class="required focus" Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work Amy, thanks for your contribution. All works as expected, Passing QA
Created attachment 115554 [details] [review] Bug 27458: Set focus for cursor to Credit type code field Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD amended patch: Edit commit title
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.
> Feel free to ask if it's needed. actually credit_types.tt didn't exist in 19.11