We want admin/cities.pl to be using as much DT features as possible to be used as an example. We must add the column visibility.
Created attachment 115250 [details] [review] Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there.
Test on PTFS sandbox : First step is OK : Columns can be hide or show, by clicking in the popup "columns" in admin/cities.pl page Second step works partially : - some default settings can be set from the admin/columns_settings.pl#cities page. - Not toggled functionality works on the admin/cities.pl page, the choosen columns doesn't shown anymore in the popup - BUT hidding columns by default doesn't work in the admin/cities.pl page : the chosen columns are ever shown, even after refreshing or reloading the page, or cleaning cookies and cache of the internet browser.
I have the same problem as Pascale, the TableSettings do not hide the columns. Also to be consistent the 'Actions' column should include: cannot_be_toggled: 1 cannot_be_modified: 1
Created attachment 119233 [details] [review] Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there.
(In reply to Lucas Gass from comment #3) > I have the same problem as Pascale, the TableSettings do not hide the > columns. Will be fixed by bug 28096. > Also to be consistent the 'Actions' column should include: > > cannot_be_toggled: 1 > cannot_be_modified: 1 Done.
Created attachment 119238 [details] [review] Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 119799 [details] [review] Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 27402 and Bug 28096 both not in 20.11.x