koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:<p>If you have a shibboleth account, please <a href="[% shibbolethLoginUrl | $raw %]">click here</a> to login.</p> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt: <p><a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to login</a>.<p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page.
There is also this occurrence: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: <p>If you have a Shibboleth account, please <a href="[% shibbolethLoginUrl | $raw %]">click here to login</a>.</p>
Created attachment 115402 [details] [review] Bug 27470: Improved link text for shibboleth login TEST PLAN: 1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do this by following https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata 2) If you are logged in Koha, log out, on the login screen the text at the top should say the following, "If you have a shibboleth account, see Shibboleth Login to login." 3) Then go to the OPAC, if you are logged in, log out. Then go to the login screen, the text at the top should say the following "If you have a Shibboleth account, see Shibboleth Account to login." Then the patch has worked
Created attachment 115403 [details] [review] Bug 27470: Improved link text for logging into CAS TEST PLAN 1) First login and go to system prefeences, search CAS and enable casAuthentication. 2) restart_all in the terminal 3) Log out of koha 4) Under the usual login, and under Cas login there should be a message which says: "If you have a CAS account, see CAS login to login." If so, the patch has worked
Patch no longer cleanly applies to current master.
Created attachment 133508 [details] [review] Bug 27470: Improved link text for shibboleth login TEST PLAN: 1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do this by following https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata 2) If you are logged in Koha, log out, on the login screen the text at the top should say the following, "Log in using a Shibboleth account" Sponsored-by: Catalyst IT
Created attachment 133579 [details] [review] Bug 27470: Improved link text for shibboleth login TEST PLAN: 1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do this by following https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata 2) If you are logged in Koha, log out, on the login screen the text at the top should say the following, "Log in using a Shibboleth account" Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133881 [details] [review] Bug 27470: Improved link text for shibboleth login TEST PLAN: 1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do this by following https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata 2) If you are logged in Koha, log out, on the login screen the text at the top should say the following, "Log in using a Shibboleth account" Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Added 22_05 keyword to make sure it gets picked.. It's a nice little improvement :)
(In reply to Martin Renvoize from comment #8) > Added 22_05 keyword to make sure it gets picked.. It's a nice little > improvement :) Yep, picked just before string freeze ;)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Wrong bug, sorry!