<script>window.location.href="/cgi-bin/koha/authorities/detail.pl?authid=[% recordid1 | html %]";</script> koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt: <p>The merging was successful. <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% recordid1 | uri %]">Click here to see the merged record.</a></p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. To reproduce: 1. Create or have two authorities 2. Do a search in Authorities 3. Click Actions -> merge for one authority 4. After the page reloads to show we are merging, click Actions -> Merge for the next authority 5. Go Next until the merge is complete Notice you don't even see the 'The merging was successful' message, because of the javascript that redirects you. To patch: delete the script line and reword the 'Click here' message
Created attachment 115399 [details] [review] Bug 27471: Link text change so is more helpful. Test PLan: 1. Complete the above steps to reproduce, specially noting the last step 2. Apply the patch 3. Complete step 1 again, but now notice how the links says "This sentence is the link to ..."
"This sentence is the link to see the merged record." doesn't make sense to me. How about "View the merged record" ?
Created attachment 115457 [details] [review] Bug 27471: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step 2. Apply the path 3. Complete step 1 again, but now notice how the link says "View the merged record"
Created attachment 115480 [details] [review] Bug 27471: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step 2. Apply the path 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
The description of this bug indicates the javascript redirect would be removed. Please implement that change in the patch set, or alter the bug description to match the patch behavior. Thanks!
Created attachment 115622 [details] [review] Bug 27471: redirects user to page, link text changed Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record
I wonder if the link and the redirect where thought to work as some kind of non-Javascript fallback? If Javascript is enabled, redirect automatically... if not, display the link. But seeing a success message is nice too!
Created attachment 115639 [details] [review] Bug 27471: Change auth merge success link text and don't redirect Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115678 [details] [review] Bug 27471: Change auth merge success link text and don't redirect Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x