koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt: <p>The merge was successful. <a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% ref_biblionumber | uri %]">Click here to see the merged record.</a></p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. To reproduce: 1. have or create two bibliographic records 2. in your terminal run sudo koha-rebuild-zebra -f -b -v kohadev 3. do a catalog search that will return both records in the results 4. select the checkboxes for both records 5. click edit->merge and continue the process of merging two records 6. notice the 'click here' message after successfully merging
Created attachment 115389 [details] [review] Bug 27472: Changed link text from "click here" to "click this sentence". Test plan: 1. Complete the steps above, specially noting the last step. 2. Apply patch 3. Complete the steps above, but now notice how the link says "Click this sentence..." after merging.
Created attachment 115391 [details] [review] Bug 27472: Link text change so is more helpful. Test Plan: 1. Complete the steps to reproduce above, specially noting the last step 2. Apply the patch 3. Complete step 1 again, but now notice how the link says "This sentence is the link to ..."
"This sentence is the link to see the merged record." doesn't make sense to me, it sounds like placeholder text. How about "View the merged record" ?
Created attachment 115453 [details] [review] Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record"
Created attachment 115542 [details] [review] Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 115562 [details] [review] Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 115692 [details] [review] Bug 27472: Improve link text (merge.tt) Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x