koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt: <a href="/cgi-bin/koha/patroncards/edit-profile.pl?op=new">Click here to define a printer profile.</a> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. to reproduce: go to Tools -> patron card creator ensure you have no printer profiles go to add a new card template notice that next to Profile there is a 'click here' link we want to reword this.
Created attachment 115401 [details] [review] Bug 27475 - Improve link text to define a patron card printer profile if none are defined This patch changes the text on the text link for defining a printer profile to make it more clear. It does this by removing the "Click here". Test plan: 1. Navigate from home -> tools -> patron card creator 2. Ensure you have no printer profiles 3. Select "new", and create a new card template 4. Note the text link "Click here to define a new printer profile" 5. Apply the patch, and repeat steps 1-3 6. Note that the "Click here" has been removed.
Created attachment 115447 [details] [review] Bug 27475: Improve link text to define a patron card printer profile if none are defined This patch changes the text on the text link for defining a printer profile to make it more clear. It does this by removing the "Click here". Test plan: 1. Navigate from home -> tools -> patron card creator 2. Ensure you have no printer profiles 3. Select "new", and create a new card template 4. Note the text link "Click here to define a new printer profile" 5. Apply the patch, and repeat steps 1-3 6. Note that the "Click here" has been removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 115513 [details] [review] Bug 27475: Improve link text to define a patron card printer profile if none are defined This patch changes the text on the text link for defining a printer profile to make it more clear. It does this by removing the "Click here". Test plan: 1. Navigate from home -> tools -> patron card creator 2. Ensure you have no printer profiles 3. Select "new", and create a new card template 4. Note the text link "Click here to define a new printer profile" 5. Apply the patch, and repeat steps 1-3 6. Note that the "Click here" has been removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Welcome to the team James :) Passing QA
Pushed to master for 21.05, thanks to everybody involved!
I propose not to backport since it is still in work (children of Bug 26722) Enhancement not pushed to 20.11.x