find all of the places in the code that refer to the 'gist' system preference and rename them to 'TaxRates' write an atomic update to rename the gist system preference to TaxRates in the preferences table in the database rename the gist syspref in sysprefs.sql refer to bug 10328 for an example
Created attachment 115462 [details] [review] Bug 27485: Rename system preference gist to TaxRates Test Plan: 1. Create a vendor 2. Create a basket 3. Add an order to the basket (note the existence of the option 'gist' 4 Apply patch 5. Create another order (note the existence of the option 'TaxRates' instead) 6. Run 'prove t/Prices.t' to confirm the tests were successful 7. If everything above is correct then patch was successful
Created attachment 115644 [details] [review] Bug 27485: Rename system preference gist to TaxRates Test Plan: 1. Create a vendor 2. Create a basket 3. Add an order to the basket (note the existence of the option 'gist' 4 Apply patch 5. Create another order (note the existence of the option 'TaxRates' instead) 6. Run 'prove t/Prices.t' to confirm the tests were successful 7. If everything above is correct then patch was successful Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
As hard as I tried, I couldn't find any remaining gist!
QA: Looking here
Created attachment 115665 [details] [review] Bug 27485: Rename system preference gist to TaxRates Test Plan: 1. Create a vendor 2. Create a basket 3. Add an order to the basket (note the existence of the option 'gist' 4 Apply patch 5. Create another order (note the existence of the option 'TaxRates' instead) 6. Run 'prove t/Prices.t' to confirm the tests were successful 7. If everything above is correct then patch was successful Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Great Mazen. The name of this pref was one of the most confusing in Koha for a long time.
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x