find all of the places in the code that refer to the 'delimiter' system preference and rename them to 'CSVDelimiter' write an atomic update to rename the delimiter system preference to CSVDelimiter in the preferences table in the database rename the delimiter syspref in sysprefs.sql refer to bug 10328 for an example
Created attachment 115485 [details] [review] Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name)
This works well and the test passes, but the QA tool raises this warning: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/.basketgroup.tt.swp FAIL invalid file This file must not be added to the codebase
Created attachment 115618 [details] [review] Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name)
Created attachment 115742 [details] [review] Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described.
Created attachment 115996 [details] [review] Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115997 [details] [review] Bug 27486: (QA follow-up) Fix occurence in aqplan.pl There was another mention of the old system preference name in the budget planning code. This patch replaces it with the new name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 116009 [details] [review] Bug 27486: Replace one missing occurrence
Pushed to master for 21.05, thanks to everybody involved!
Created attachment 116140 [details] [review] Bug 27486: Fix UsageStats.t
Follow-up pushed to master.
Enhancement not pushed to 20.11.x