Can be very useful to know on any page of staff interface Koha version. I made a plugin : https://github.com/biblibre/koha-plugin-intranet-version-in-header But seems better to provide a patch.
Created attachment 115443 [details] [review] Bug 27497: Display Koha version in header under logo in staff interface Can be very useful to know on any page of staff interface Koha version. I made a plugin : https://github.com/biblibre/koha-plugin-intranet-version-in-header But seems better to provide a patch. This patch created a new include logo.inc that contains the logo and version, called in all header includes. It adds a div with id "header_logo" to be able to set float on the parent of logo and version. So h1#logo must be replaced in all CSS files. It removes in staff-global.scss rules about h1#logo since they all are in #logo. Test plan: 1) Go to staff interface 2) Check you see Koha version YY.MM.XX under logo 3) Check it is responsive 4) Check it is not displayed when printing home page 4) Check it is not displayed when printing receipt invoice 5) Check all modules home page 6) Check right-to-left display
Created attachment 115444 [details] [review] Bug 27497: [DO NOT PUSH] Compiled CSS
Created attachment 115445 [details] Screenshot
(In reply to Fridolin Somers from comment #2) > Bug 27497: [DO NOT PUSH] Compiled CSS I don't think it's necessary to submit compiled CSS anymore, is it?
I think the lower right-hand side of the page would be a better place to display the version number. I think if my staff sees just 20.05.06 floating under the logo I will get lots of questions regarding what it is. I also think it needs to have the word 'version' included in order to make it very explicit as to what the numbers mean, such as 'version 20.05.06'. Being in the lower right-hand side of the page mirrors the standard placement of the "Powered by Koha" that displays on the OPAC.
(In reply to Barbara Johnson from comment #5) > I think the lower right-hand side of the page would be a better place to > display the version number. I think if my staff sees just 20.05.06 floating > under the logo I will get lots of questions regarding what it is. > > I also think it needs to have the word 'version' included in order to make > it very explicit as to what the numbers mean, such as 'version 20.05.06'. > > Being in the lower right-hand side of the page mirrors the standard > placement of the "Powered by Koha" that displays on the OPAC. I agree with Barbara. I don't like seeing the version floating under the logo. One of the first things I'd do on a new Koha would be to hide that. This patch seems useful on its own without the version number though! Good bit of refactoring.
(In reply to Barbara Johnson from comment #5) > I think the lower right-hand side of the page would be a better place to > display the version number. I think if my staff sees just 20.05.06 floating > under the logo I will get lots of questions regarding what it is. > > I also think it needs to have the word 'version' included in order to make > it very explicit as to what the numbers mean, such as 'version 20.05.06'. Ok good idea > > Being in the lower right-hand side of the page mirrors the standard > placement of the "Powered by Koha" that displays on the OPAC. Ok. But actually in staff interface, if there is no language select possibility there is no lower bar in the page. Is it OK to always show a lower floating bar to the page ? Your librarians are very happy to see the exact version of Koha so they can see what bug fix or feature is inside :D
And what do you think displaying the version below "About Koha" in main page ? Since version is displayed is this page about.pl
(In reply to Fridolin Somers from comment #8) > And what do you think displaying the version below "About Koha" in main page > ? > Since version is displayed is this page about.pl +1 I really like this idea.
Created attachment 115834 [details] [review] Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item.
*** Bug 27097 has been marked as a duplicate of this bug. ***
Created attachment 115998 [details] [review] Bug 27497: Display Koha version in header under logo in staff interface Can be very useful to know on any page of staff interface Koha version. I made a plugin : https://github.com/biblibre/koha-plugin-intranet-version-in-header But seems better to provide a patch. This patch created a new include logo.inc that contains the logo and version, called in all header includes. It adds a div with id "header_logo" to be able to set float on the parent of logo and version. So h1#logo must be replaced in all CSS files. It removes in staff-global.scss rules about h1#logo since they all are in #logo. Test plan: 1) Go to staff interface 2) Check you see Koha version YY.MM.XX under logo 3) Check it is responsive 4) Check it is not displayed when printing home page 4) Check it is not displayed when printing receipt invoice 5) Check all modules home page 6) Check right-to-left display Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Created attachment 115999 [details] [review] Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Created attachment 116103 [details] [review] Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
It feels like most/all of the changes in the first page might no longer be needed with the second patch. The changes don't hurt and are a bit of a little clean-up, so I'd be ok with them, but maybe Owen wants to weigh in?
(In reply to Fridolin Somers from comment #8) > And what do you think displaying the version below "About Koha" in main page > ? > Since version is displayed is this page about.pl Can we also add it in main page ? "About Koha" under "Koha administration" ?
I agree with Fridolin. My hope was that the version would display more prominently without having to click on 'About Koha' or 'More.' I attached a screenshot that shows the version in the lower right hand corner of the main/hone page.
Created attachment 116172 [details] Display version in lower right corner of home page in staff client
(In reply to Barbara Johnson from comment #17) > I agree with Fridolin. My hope was that the version would display more > prominently without having to click on 'About Koha' or 'More.' I attached a > screenshot that shows the version in the lower right hand corner of the > main/hone page. I like the sound of this too
(In reply to Barbara Johnson from comment #18) > Created attachment 116172 [details] > Display version in lower right corner of home page in staff client Showing at the bottom may not be visible on a small screen. Or make it float ? add in into language bar ? I propose in the header : https://github.com/biblibre/koha-plugin-intranet-version-in-header/blob/trunk/Screenshot.png Or maybe above the news in the main page ?
And if all these choices aren't obvious enough? ;) https://snipboard.io/1POznS.jpg
(In reply to Fridolin Somers from comment #20) > Showing at the bottom may not be visible on a small screen. I doubt we'd need to worry about a small screen for the staff interface though? > I propose in the header : > https://github.com/biblibre/koha-plugin-intranet-version-in-header/blob/ > trunk/Screenshot.png I think it looks strange there. Like it's a navigation option when it's not. -- I've tried to look for examples elsewhere, but I have 0 examples where the version number is shown on the main screen of the application. So maybe we are going about this the wrong way. It's tempting to add a News item mentioning upgrades to the staff interface, although that might interfere with how people use the News system in practice. -- Or... we just keep it as a plugin.
I propose we vote in mailling list.
(In reply to Fridolin Somers from comment #23) > I propose we vote in mailling list. Sounds good to me. I don't feel passionately enough about this one to advocate any particular position.
(In reply to Barbara Johnson from comment #18) > Created attachment 116172 [details] > Display version in lower right corner of home page in staff client I vote for this option :-D I'd put 'powered by Koha 20.05.08' instead, but generally prefer this option.
I like Barbara's suggestion at the bottom of the page, like "credits". It also doesn't work for in the top navigation, as this is misleading and we already have a lot of stuff going on there. I'd also be happy with the initial patch here showing it in the pull down.
I prefer the lower right-hand corner option. Displaying it like "credits" really makes sense to me.
(In reply to Barbara Johnson from comment #27) > I prefer the lower right-hand corner option. Displaying it like "credits" > really makes sense to me. OK seems the most wanted option. And its really a small change, which will be easy to hide. I'm on a patch.
Created attachment 116703 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page
Created attachment 116704 [details] Screenshot with patch
Created attachment 116706 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 116781 [details] Version displaying in center of page The version is not appearing where expected for me. Instead of appearing in the lower-right corner, it's beneath the middle column (directly beneath "Authorities")
Created attachment 116782 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michael Adamyk <madamyk@ckls.org>
The version did not appear where expected in my sandbox. I'm marking it as "Failed QA" so you can take another look at it.
(In reply to Michael Adamyk from comment #34) > The version did not appear where expected in my sandbox. I'm marking it as > "Failed QA" so you can take another look at it. Ah, I dont know if sandbox can update CSS files from SCSS ? https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Can someone confirm ?
@Michael Adamyk Can you run manually 'yarn build' please ?
I'm afraid I don't know enough about Koha to know how to do the SCSS or yard rebuild. Can someone else test and see if it's working for you?
(In reply to Michael Adamyk from comment #37) > I'm afraid I don't know enough about Koha to know how to do the SCSS or yard > rebuild. Can someone else test and see if it's working for you? Hi Michael, if you are using the sandboxes, there is a new option to do this from there quite easily: If you look here http://sandboxes.ptfs-europe.co.uk/# you can pick "Build CSS" from the Actions pull down. That will do the trick.
Created attachment 118564 [details] Screenshot I am sorry, I am not sure about this one. It looks a little too 'detached' to me? Attaching a screenshot to make sure I am looking at the right thing. No languages installed.
I realize I like the screenshot 1 best still.
I agree with Katrin about this looking detached. It’s just floating in thin air and looks really odd in that placement. Screenshot 1 would be my preference too.
(In reply to Katrin Fischer from comment #39) > Created attachment 118564 [details] > Screenshot > > I am sorry, I am not sure about this one. It looks a little too 'detached' > to me? Attaching a screenshot to make sure I am looking at the right thing. > No languages installed. Agreed
Created attachment 118956 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page
Ahhh my mistake, my patch adds to SCSS float: left We want it at right, fixed : float: right I've uploaded fixed patch, so we need signoff again.
Created attachment 119005 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 119006 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 119821 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 119822 [details] Screenshot of placement on the right
Created attachment 119823 [details] [review] Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Sorry to say, I still feel like this is not quite where it should be :( (see screenshot) But we got 2 sign-offs and I don't want to block this longer as it can be hidden as well. I think my problem is, that I think it should "float" more at the bottom, right above or included in the language chooser if that's visible. I'd also be happy to have it included on the "About" after thinking about this more as placing it nicely has been proven so difficult.
(In reply to Katrin Fischer from comment #50) > Sorry to say, I still feel like this is not quite where it should be :( (see > screenshot) Agreed > I think my problem is, that I think it should "float" more at the bottom, > right above or included in the language chooser if that's visible. Agreed, although I'd say "fixed" to the bottom. -- Based on the last screenshot, it does not look very good, so I'll probably just hide it on all my installs. I'd say just always have a bottom bar on the staff interface, and incorporate the language choose into that bottom bar. Shouldn't be that hard at a glance.
Why is it PQA if there is still discussion and the solution does not make everybody happy? :) It is displaying: "Version 20.12.00", when it is actually "20.12.00.034". Why don't we display the exact version?
(In reply to Jonathan Druart from comment #52) > Why is it PQA if there is still discussion and the solution does not make > everybody happy? :) > > > It is displaying: "Version 20.12.00", when it is actually "20.12.00.034". > Why don't we display the exact version? I am actually happy with that :) The "database update number" isn't appearing anywhere in documentation like release notes, I think it would only be confusing. The idea was to make them more aware of the version they are using, I think less numbers are more here.
Frido, I like what you said about adding the version as a tooltip over the Koha logo at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667#c13 That would be very usable but it wouldn't be ugly or disruptive to staff users.
Actually, it looks like we have it in a meta tag (at least in 21.11) so maybe it's not that necessary after all...
I think the patch we have should be accepted.
Letting Tomas decide then now.
Pushed to master for 22.11. Nice work everyone, thanks!
Cool, thank you all :D
Enhancement will not be backpoted to 22.05.x series