Created attachment 115489 [details] [review] Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon
Created attachment 115540 [details] [review] Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I love new item type images! :)
As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please?
Created attachment 115705 [details] [review] Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC
Created attachment 115751 [details] [review] Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 115752 [details] [review] Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC
Created attachment 115842 [details] [review] Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha?
Created attachment 123192 [details] [review] Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC
Created attachment 123276 [details] [review] Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123931 [details] [review] Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Based on bug 27522 comment 22 I have decided to restore the original version of the icon.
Pushed to master for 21.11, thanks to everybody involved!