Created attachment 115730 [details] [review] Bug 27538: fix correlation of fields in Holds to Pull table Bottom filtering row of "Holds to pull" table do not correlate to other ones, columns diverged from "Call numbers" cell: it should be under "Available call numbers" while it's under "Available barcodes", and so on to the last cell (while number of cells still adjusted). To reproduce: 1) Head to the Holds to Pull page, check that bottom filtering row shifted to the left by one, starting from the "Call number" column and don't correlate to the upper table (for example, "Call numbers" cell should be under "Available call numbers" while it's under "Available barcodes"), and so on for all cells till the end of the filtering row. 2) Apply patch. 3) Refresh Holds to Pull page and ensure that all filtering row columns correlate to other rows columns correctly.
Created attachment 115777 [details] [review] Bug 27538: fix correlation of fields in Holds to Pull table Bottom filtering row of "Holds to pull" table do not correlate to other ones, columns diverged from "Call numbers" cell: it should be under "Available call numbers" while it's under "Available barcodes", and so on to the last cell (while number of cells still adjusted). To reproduce: 1) Head to the Holds to Pull page, check that bottom filtering row shifted to the left by one, starting from the "Call number" column and don't correlate to the upper table (for example, "Call numbers" cell should be under "Available call numbers" while it's under "Available barcodes"), and so on for all cells till the end of the filtering row. 2) Apply patch. 3) Refresh Holds to Pull page and ensure that all filtering row columns correlate to other rows columns correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 116100 [details] [review] Bug 27538: fix correlation of fields in Holds to Pull table Bottom filtering row of "Holds to pull" table do not correlate to other ones, columns diverged from "Call numbers" cell: it should be under "Available call numbers" while it's under "Available barcodes", and so on to the last cell (while number of cells still adjusted). To reproduce: 1) Head to the Holds to Pull page, check that bottom filtering row shifted to the left by one, starting from the "Call number" column and don't correlate to the upper table (for example, "Call numbers" cell should be under "Available call numbers" while it's under "Available barcodes"), and so on for all cells till the end of the filtering row. 2) Apply patch. 3) Refresh Holds to Pull page and ensure that all filtering row columns correlate to other rows columns correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Caused by: commit fe84c3acba33af7a2fb27643f6b5f9129c329b36 Bug 23485: Show barcode in holds to pull
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Missing dependencies for 19.11.x, it shouldn't be affected, no backport.