After an ILL request has "Place request with partner libraries" status, is it no longer possible to cancel it via the "Revert request" option as this button is not displayed. This should be possible.
Created attachment 115741 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated
TEST PLAN - Create a ILL request - Place the request with partners - Modify the request => TEST: Observe that the "Revert request" button is displayed
The button text "Revert Request" has incorrect capitalization. When I run the test I get these failures: # Failed test 'Status Graph tests' # Failed test 'Checking out' I don't know if that's relevant.
Created attachment 147897 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 147898 [details] [review] Bug 27542: (follow-up) Capitalization
Created attachment 147899 [details] [review] Bug 27542: (follow-up) Fix unit test
We've been backporting this into production for 2 years now.. be nice to see it get into 23.05 ;)
Created attachment 150641 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Created attachment 150642 [details] [review] Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Created attachment 150643 [details] [review] Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Added SO lines from customers using this in production. My feeling is we should go straight to PQA here.. the code is well and truly tested and working.
Created attachment 151458 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 151459 [details] [review] Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 151460 [details] [review] Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not backported to 23.05.x