Bug 27542 - It should be possible to cancel an ILL request sent to a partner
Summary: It should be possible to cancel an ILL request sent to a partner
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-25 11:18 UTC by Andrew Isherwood
Modified: 2023-12-28 20:47 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 27542: Allow cancellation of partner ILL (2.10 KB, patch)
2021-01-25 11:22 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 27542: Allow cancellation of partner ILL (2.16 KB, patch)
2023-03-08 11:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: (follow-up) Capitalization (879 bytes, patch)
2023-03-08 11:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: (follow-up) Fix unit test (1.75 KB, patch)
2023-03-08 11:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: Allow cancellation of partner ILL (2.22 KB, patch)
2023-05-04 10:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: (follow-up) Capitalization (933 bytes, patch)
2023-05-04 10:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: (follow-up) Fix unit test (1.80 KB, patch)
2023-05-04 10:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27542: Allow cancellation of partner ILL (2.27 KB, patch)
2023-05-19 09:00 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 27542: (follow-up) Capitalization (992 bytes, patch)
2023-05-19 09:00 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 27542: (follow-up) Fix unit test (1.86 KB, patch)
2023-05-19 09:00 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2021-01-25 11:18:02 UTC
After an ILL request has "Place request with partner libraries" status, is it no longer possible to cancel it via the "Revert request" option as this button is not displayed.

This should be possible.
Comment 1 Andrew Isherwood 2021-01-25 11:22:45 UTC
Created attachment 115741 [details] [review]
Bug 27542: Allow cancellation of partner ILL

This commit enables the display of the "Revert request" button when a
request's status is GENREQ / "Requested from partners"

The relevant unit test has also been updated
Comment 2 Andrew Isherwood 2021-01-25 11:25:10 UTC
TEST PLAN

- Create a ILL request
- Place the request with partners
- Modify the request
=> TEST: Observe that the "Revert request" button is displayed
Comment 3 Owen Leonard 2022-09-02 11:00:25 UTC
The button text "Revert Request" has incorrect capitalization.

When I run the test I get these failures:

#   Failed test 'Status Graph tests'
#   Failed test 'Checking out'

I don't know if that's relevant.
Comment 4 Martin Renvoize 2023-03-08 11:23:55 UTC
Created attachment 147897 [details] [review]
Bug 27542: Allow cancellation of partner ILL

This commit enables the display of the "Revert request" button when a
request's status is GENREQ / "Requested from partners"

The relevant unit test has also been updated

Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-03-08 11:23:57 UTC
Created attachment 147898 [details] [review]
Bug 27542: (follow-up) Capitalization
Comment 6 Martin Renvoize 2023-03-08 11:24:00 UTC
Created attachment 147899 [details] [review]
Bug 27542: (follow-up) Fix unit test
Comment 7 Martin Renvoize 2023-03-08 11:24:56 UTC
We've been backporting this into production for 2 years now.. be nice to see it get into 23.05 ;)
Comment 8 Martin Renvoize 2023-05-04 10:38:54 UTC
Created attachment 150641 [details] [review]
Bug 27542: Allow cancellation of partner ILL

This commit enables the display of the "Revert request" button when a
request's status is GENREQ / "Requested from partners"

The relevant unit test has also been updated

Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 9 Martin Renvoize 2023-05-04 10:38:57 UTC
Created attachment 150642 [details] [review]
Bug 27542: (follow-up) Capitalization

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 10 Martin Renvoize 2023-05-04 10:38:59 UTC
Created attachment 150643 [details] [review]
Bug 27542: (follow-up) Fix unit test

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 11 Martin Renvoize 2023-05-04 10:39:47 UTC
Added SO lines from customers using this in production.

My feeling is we should go straight to PQA here.. the code is well and truly tested and working.
Comment 12 Pedro Amorim 2023-05-19 09:00:49 UTC
Created attachment 151458 [details] [review]
Bug 27542: Allow cancellation of partner ILL

This commit enables the display of the "Revert request" button when a
request's status is GENREQ / "Requested from partners"

The relevant unit test has also been updated

Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 13 Pedro Amorim 2023-05-19 09:00:52 UTC
Created attachment 151459 [details] [review]
Bug 27542: (follow-up) Capitalization

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 14 Pedro Amorim 2023-05-19 09:00:55 UTC
Created attachment 151460 [details] [review]
Bug 27542: (follow-up) Fix unit test

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 15 Tomás Cohen Arazi 2023-09-01 15:09:04 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 16 Fridolin Somers 2023-09-08 06:15:11 UTC
Enhancement not backported to 23.05.x