Created attachment 115781 [details] [review] Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console.
Created attachment 115794 [details] [review] Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: - When using koha-testing-docker the warnings are logged to /var/log/koha/kohadev/plack-intranet-error.log
Created attachment 116099 [details] [review] Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I've reformatted the commit message a little bit for better readability on command line (adding line breaks).
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Backported: Pushed to 19.11.x branch for 19.11.15