Created attachment 115783 [details] [review] Bug 27549: "use of uninitialized value" warning on renew.pl On the beginning we have empty "barcode" parameter for this form, but that not taken into account in regular expression warning emitted: "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47." in renew.pl Fixed by making $barcode to become an empty string by default. To reproduce: 1) Head over to the "Circulation -> Renew" page. 2) Check intranet-error.log there will be a warning "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47". 3) Apply the patch, refresh the "Renew" page. 4) Ensure that the new "use of uninitialized value" warnings didn't appear in the console.
Created attachment 115795 [details] [review] Bug 27549: "use of uninitialized value" warning on renew.pl On the beginning we have empty "barcode" parameter for this form, but that not taken into account in regular expression warning emitted: "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47." in renew.pl Fixed by making $barcode to become an empty string by default. To reproduce: 1) Head over to the "Circulation -> Renew" page. 2) Check intranet-error.log there will be a warning "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47". 3) Apply the patch, refresh the "Renew" page. 4) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: - When using koha-testing-docker the warnings are logged to /var/log/koha/kohadev/plack-intranet-error.log
Created attachment 116098 [details] [review] Bug 27549: "use of uninitialized value" warning on renew.pl On the beginning we have empty "barcode" parameter for this form, but that not taken into account in regular expression warning emitted: "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47." in renew.pl Fixed by making $barcode to become an empty string by default. To reproduce: 1) Head over to the "Circulation -> Renew" page. 2) Check intranet-error.log there will be a warning "Use of uninitialized value $barcode in substitution (s///) at /usr/share/koha/intranet/cgi-bin/circ/renew.pl line 47". 3) Apply the patch, refresh the "Renew" page. 4) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Backported: Pushed to 19.11.x branch for 19.11.15