addbiblio.pl takes a searchid parameter which is built into several urls, however, when adding a new biblio and not coming from a search this value is never initialized and there is a warn
Created attachment 116031 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn
Created attachment 117238 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 117366 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.05, thanks to everybody involved!
In my opinion we should use q{} for empty strings.
Pushed to 20.11.x for 20.11.04
Pushed to 20.05.x for 20.05.10
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.