+1 on this -- this is a really common request when training new Koha users!

Yes, we would be interested in this. Manually placing holds is very tedious and time consuming.

*** Bug 29039 has been marked as a duplicate of this bug. ***

+1

This would be a fantastic and much needed feature!

Patrons ask us about this all the time. 
This would be an awesome feature.

Our Collection Development team processes hundreds of patron suggestions each month. This feature would be highly important to our library system. Please develop this feature!!!

This would be a great feature to add to Koha.

This would be an awesome feature, especially if we could somehow get it to work with EDI ordering, not just title by title purchasing.

We would definitely be in on helping fund this enhancement. We do a TON of patron suggestions.

We are interested in this enhancement.  We frequently have people make suggestions and want the book when it's been ordered.

We have discovered something similar for acquisition orders the other day and kept wondering how this could work.

A suggestion might not be linked to a bibliographic record when it's accepted. So would this be limited to suggestions on existing records or for suggestions, that are also handled through acquisitions?

Maybe it would be nice to be able to manually link a suggestion to a bibliographic record? This could make it easier to add this enhancement on top.

> Maybe it would be nice to be able to manually link a suggestion to a
> bibliographic record? This could make it easier to add this enhancement on
> top.

Strong agree! I filed bug 31617 for this. We already have the database field for it.

Hi,

We're [SLO County Libraries] also interested in having this feature added to the Suggest a Title module.

Thank you,
Charlie

Created attachment 159524 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Created attachment 159525 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Created attachment 159526 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Created attachment 159533 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Created attachment 159534 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Created attachment 159535 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

I want to note here that this feature will create holds that would not otherwise be allowed. It'll put holds on bibs without items and on bibs where all items are of an unholdable item type. I guess that shouldn't be an issue, since staff are purposefully ordering the title, but I wanted to make sure it was explicitly acknowledged.

Created attachment 159537 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159538 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159539 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159540 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159541 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159542 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 159786 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Created attachment 159787 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Created attachment 159788 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

All working well and no regressions, QA scripts happy.

Great addition, thanks Nick

Passing QA

Patch no longer applies and I'd prefer a rebase by the author. With the new list on the dashboard this should come right back up in the queue.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions
Using index info to reconstruct a base tree...
M	installer/data/mysql/mandatory/sysprefs.sql
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
Applying: Bug 27595: Add place_hold method to Koha::Suggestion
Applying: Bug 27595: Place holds when ordering from a suggestion
Using index info to reconstruct a base tree...
M	acqui/addorder.pl
Falling back to patching base and 3-way merge...
Auto-merging acqui/addorder.pl
CONFLICT (content): Merge conflict in acqui/addorder.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 27595: Place holds when ordering from a suggestion
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-27595-Place-holds-when-ordering-from-a-suggest-4__rodz_.patch

Created attachment 163331 [details] [review]
Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Created attachment 163332 [details] [review]
Bug 27595: Add place_hold method to Koha::Suggestion

This patch adds anew method to allow placing a hold from a purchase suggestion

To test:
prove -v t/db_dependent/Suggestions.t

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Created attachment 163333 [details] [review]
Bug 27595: Place holds when ordering from a suggestion

This patch updates the ordering code to place a hold when adding to a basket from a
suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled.

To test:
1 - Apply all patches
2 - updatedatabase
3 - See new system preference PlaceHoldsOnOrdersFromSuggestions
4 - Create a new purchase suggestion, mark it accepted
5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion'
6 - Complete order, confirm no hold was placed
7 - Enable the new system preference
8 - Repeast 4-6
9 - Confirm a hold was placed

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Back on this one, thanks for the rebase, Nick!

Pushed for 24.05!

Well done everyone, thank you!

Enhancement not pushed to 23.11.x

Hmm, I was just documenting this and noticed that the new syspref is
in the Subgroup "Printing" of the Acquisitions system preferences.
Why "Printing"?

(In reply to Philip Orr from comment #38)
> Hmm, I was just documenting this and noticed that the new syspref is
> in the Subgroup "Printing" of the Acquisitions system preferences.
> Why "Printing"?

That does indeed seem odd...

(In reply to Martin Renvoize from comment #39)
> (In reply to Philip Orr from comment #38)
> > Hmm, I was just documenting this and noticed that the new syspref is
> > in the Subgroup "Printing" of the Acquisitions system preferences.
> > Why "Printing"?
> 
> That does indeed seem odd...

Could you please file a bug to move into a better spot? We are in string frezee bug can fix that for .01

Done!
Bug 36936:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36926

Thanks! Can I also squeeze for your some release notes? :)

Sure thing, but it will be first thing tomorrow morning, I'm busy with other things rest of the day today :)

(In reply to Philip Orr from comment #43)
> Sure thing, but it will be first thing tomorrow morning, I'm busy with other
> things rest of the day today :)

This week is fine - thanks!!

Will this be available in the upcoming 24.05 upgrade?  I have an acquisitions person who is anxious to use it.

(In reply to Kim Gnerre from comment #45)
> Will this be available in the upcoming 24.05 upgrade?  I have an
> acquisitions person who is anxious to use it.

You can always see the versions a feature is included in in the "Version(s) released in:" in the right column on the left. This was first release din 24.05.00, so will be included.

Thank you!  I completely missed that.